Fix double free messages in baidu-std#2924
Merged
Merged
Conversation
Contributor
|
LGTM |
Contributor
|
parse 失败会在什么场景下触发呢？ |
Contributor
Author
pb反序列化失败或者解压失败之类的吧。 |
Contributor
|
请求都是client send 的， 从代码上看应该是parse 失败，想了解根因，什么场景下会导致 parse 失败？网络错误，超时，或者 server 内部的一些错误 |
Contributor
Author
|
一般是client发的请求包有问题导致的吧。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
SendRpcResponse中会统一归还messages，不需要在ProcessRpcRequest中提前归还。
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: